Mono collector: replace pair of ints with Range #77818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camelid
added
the
C-cleanup
|
Heh cool change. I can't think of any reason to not use @bors r+ rollup |
|
📌 Commit 0a2a68e has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 12, 2020
Mono collector: replace pair of ints with Range I found the initial PR (rust-lang#33171) that introduced this piece of code but I didn't find any information about why a tuple was preferred over a `Range<usize>`. I'm hoping there are no technical reasons to not do this.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 12, 2020
Mono collector: replace pair of ints with Range I found the initial PR (rust-lang#33171) that introduced this piece of code but I didn't find any information about why a tuple was preferred over a `Range<usize>`. I'm hoping there are no technical reasons to not do this.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#77550 (add shims for WithOptConstParam query calls) - rust-lang#77699 (Add word wrap for short descriptions) - rust-lang#77724 (Implement `AsRawFd` for `StdinLock` etc. on WASI.) - rust-lang#77746 (Fix `x.py setup` sets `changelog-seen`) - rust-lang#77784 (Fix intra-docs link in core::ffi::VaList) - rust-lang#77811 (rustdoc: Make some functions private that don't need to be public) - rust-lang#77818 (Mono collector: replace pair of ints with Range) - rust-lang#77831 (Use std methods on char instead of open coding them) - rust-lang#77852 (update url in bootstrap README (gcc-rs -> cc-rs)) - rust-lang#77863 (Remove `mark-i-m` from rustc-dev-guide maintainers) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the initial PR (#33171) that introduced this piece of code but I didn't find any information about why a tuple was preferred over a
Range<usize>.I'm hoping there are no technical reasons to not do this.